[m-rev.] for review: extend mutual tail rec optimization to functions

Peter Wang novalazy at gmail.com
Sat Sep 23 13:47:12 AEST 2017


On Sat, 23 Sep 2017 04:44:37 +1000 (AEST), "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> 
> 
> On Fri, 22 Sep 2017 15:16:03 +1000, Peter Wang <novalazy at gmail.com> wrote:
> > The compiler generates invalid C code for the attached test case
> > following this change.
> > 
> > % mmc -s hlc.gc -c test2.m
> > test2.c: In function ‘test2__test_foo_1_p_0’:
> > test2.c:633:14: error: ‘succeeded’ undeclared (first use in this function)
> >        return succeeded;
> > 	      ^
> > test2.c:633:14: note: each undeclared identifier is reported only once for each function it appears in
> > test2.c: In function ‘test2__test_bar_1_p_0’:
> > test2.c:686:14: error: ‘succeeded’ undeclared (first use in this function)
> >        return succeeded;
> 
> The attached diff fixes that bug. Post commit reviews welcome.
> 

Thanks, that's fine.

Peter


More information about the reviews mailing list