[m-rev.] for review: Enable non-tail-call warnings for?mutually-recursive code

Paul Bone paul at bone.id.au
Fri Mar 31 23:33:42 AEDT 2017


On Fri, Mar 31, 2017 at 11:11:00PM +1100, Zoltan Somogyi wrote:
> 
> 
> On Fri, 31 Mar 2017 22:28:39 +1100, Paul Bone <paul at bone.id.au> wrote:
> > I hadn't finished editing this file.  I said that I hadn't finished, but
> > would be soon, in response to your review.  I have a similar change
> > currently bootchecking and intended to commit it this evening.
> 
> Sorry about that. You said you weren't finished (but would be soon)
> on wednesday, and then yesterday you committed your updated diff.
> I took that to mean that *then* you were finished.

I understand, I was going to make it more explicit than that.
I don't mind whose changes we use, that doesn't matter in the long term.
Besides yours are more extensive. It's your call.

After this change, whoevers we use, I am finished with this file and I'll
move on to implementing optimisation of mutual tail recursion as part of
generating MLDS code from the HLDS.

Thanks.


-- 
Paul Bone
http://paul.bone.id.au


More information about the reviews mailing list