[m-rev.] for review: module_add_type_defn

Zoltan Somogyi zoltan.somogyi at runbox.com
Wed Jun 28 02:49:07 AEST 2017

On Tue, 27 Jun 2017 23:05:18 +1000 (AEST), Julien Fischer <jfischer at opturion.com>
> > Foreign MergedBody
> ?

Sorry, that was just a stale reminder to myself.

> > Make the code adding new types to the HLDS readable.
> > 
> > The motivation for this diff was that I wanted the compiler to generate
> > a warning if a module declared the same type twice. (During the cleanup
> > of unify_proc.m I did recently, I found and fixed such a duplicate
> > declaration.)
> The diff looks fine.

Thanks for the review.

Do you (or anyone else) have any opinions on the issues marked by XXXs in the
affected code, old and new? For example, the attached program compiles just fine
both before and after this diff, but I think that the definitions of foo1 and foo2
should both get an error, and one of rafe's old comments says that foo3 should
get one too. And should it be an error to declare (not define) a type in both
the interface and the implementation section of a module?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: abstract_solver_type.m
Type: text/x-objcsrc
Size: 460 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20170628/ba0021df/attachment.bin>

More information about the reviews mailing list