[m-rev.] for review: add builtin 8, 16 and 32 bit integer types -- Part 1

Peter Wang novalazy at gmail.com
Sun Jul 2 13:17:45 AEST 2017

On Sat, 1 Jul 2017 01:13:12 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
> For review by anyone.
> This diff is quite large and mostly not that interesting.  (It's fairly similar
> to the initial change that introduced uints.)  There are a couple of points I
> would like feedback on: in C grades, we map the new Mercury types directly on
> to C99's fixed sized integer types (e.g. int8_t, uint32_t etc) rather than have
> Mercury's runtime define 'MR_Integer8' or something along those lines.  One
> effect of this is that we now require a C environment that provides the header
> stdint.h.  With this change Mercury will no longer compiler in the absence of
> that header file.  Are there any objections to either of these things?

Not from me.


More information about the reviews mailing list