[m-rev.] for review: document underscores in numeric literals

Peter Wang novalazy at gmail.com
Mon Jan 16 10:38:01 AEDT 2017


On Thu, 12 Jan 2017 17:28:46 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
> 
> For review by anyone.
> 
> -----------------------
> 
> Document underscores in numeric literals.
> 
> Standardize terminology in error messages about ill-formed numeric literals.
> 
> 
> doc/reference_manual.texi:
>        Document underscores in numeric literals.
> 
>        Add a TODO comment about a future piece of work.
> 
> NEWS:
>       Announce the addition of support for underscores in numeric literals.
> 
> library/lexer.m:
>       Use the term "literal" instead of "constant" or "token" when
>       referring to numeric literals in error messages.
> 
>       s/hex/hexadecimal/ in those same error messages.
> 
> tests/hard_coded/parse_number_from_string.exp*:
> tests/invalid/invalid_{binary,decimal,hex,octal}_literal.err_exp:
>       Conform to the above change in error messages from the lexer.

That's fine.

Peter


More information about the reviews mailing list