[m-rev.] for review: update the reference manual for fixed size integer types
Julien Fischer
jfischer at opturion.com
Thu Aug 31 14:31:21 AEST 2017
Hi Zoltan,
On Thu, 24 Aug 2017, Julien Fischer wrote:
> On Thu, 24 Aug 2017, Zoltan Somogyi wrote:
>
>> On Thu, 24 Aug 2017 14:16:08 +1000 (AEST), Julien Fischer
>> <jfischer at opturion.com> wrote:
>>>
>>> diff --git a/doc/reference_manual.texi b/doc/reference_manual.texi
>>> index e837e9ecd..41a942149 100644
>>> --- a/doc/reference_manual.texi
>>> +++ b/doc/reference_manual.texi
>>> @@ -312,10 +312,19 @@ A character-code literal is @samp{0'} followed by
>>> any single character.
>>>
>>> Decimal, binary, octal and hexadecimal literals may be optionally
>>> terminated by
>>> a suffix that indicates whether the literal represents a signed or
>>> unsigned
>>> -integer.
>>> -The suffix @samp{i} indicates that the literal is a signed integer.
>>> -The suffix @samp{u} indicates that the literal is an unsigned integer.
>>> -Integer literals without such a terminating suffix are considered to be
>>> signed.
>>> +integer and what the size of that integer is.
>>> +These suffixes are:
>>> + at multitable {i_or_no_suffix} {Unsigned} {Implementation_defined}
>>> + at headitem Suffix @tab Signedness @tab Size
>>> + at item @code{i} or no suffix @tab Signed @tab Implementation-defined
>>> + at item @code{i8} @tab Signed @tab 8-bit
>>> + at item @code{i16} @tab Signed @tab 16-bit
>>> + at item @code{i32} @tab Signed @tab 32-bit
>>> + at item @code{u} @tab Unsigned @tab Implementation-defined
>>> + at item @code{u8} @tab Unsigned @tab 8-bit
>>> + at item @code{u16} @tab Unsigned @tab 16-bit
>>> + at item @code{u32} @tab Unsigned @tab 32-bit
>>> + at end multitable
>>
>> I would replace "Implementation-defined" with "Pointer-sized", with
>> a note below saying that this is the natural size of pointers on the given
>> platform
>> (which itself is of course implementation-defined). The later section
>> specifies
>> MR_Integer/MR_Unsigned anyway.
>
> Except that's only true for the C backends; for both Java and C#
> backends int and uint are 32-bits regardless of what the size of a
> pointer on the platform is.
Are you ok with comitting this as-is, or should it be adjusted further?
Julien.
More information about the reviews
mailing list