[m-rev.] for review: change the semantics of the int shift operations

Peter Wang novalazy at gmail.com
Wed Aug 30 16:43:46 AEST 2017


On Tue, 29 Aug 2017 00:43:00 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
> 
> For review by anyone.
> 
> ------------------------
> 
> Change the semantics of the int shift operations.
> 
> Change int.(<<) and int.(>>) to throw an exception if their second operand is
> not in [0, bits_per_int).  This brings them into line with the other integer
> types.
> 
> As a transitional measure, add new functions that provide the old semantics.
> 

Seems fine to me.

Peter


More information about the reviews mailing list