[m-rev.] for review: Do not opt-export `try' goals.
Paul Bone
paul at bone.id.au
Mon Sep 19 13:46:14 AEST 2016
On Mon, Sep 19, 2016 at 01:37:09PM +1000, Peter Wang wrote:
> diff --git a/library/exception.m b/library/exception.m
> index 2f133b9..ed99dda 100644
> --- a/library/exception.m
> +++ b/library/exception.m
> @@ -616,8 +616,8 @@ unsafe_call_transaction_goal(Goal, STM0, {Result, STM}) :-
>
> %---------------------------------------------------------------------------%
>
> -magic_exception_result(succeeded({})).
> -magic_exception_result(succeeded({})). % force cc_multi
> +magic_exception_result(_) :-
> + throw("magic_exception_result called").
>
> unreachable :-
> throw("unreachable code reached").
Do we want a more descriptive message there? Something that tells the user
that it should never be called directly and/or the compiler will always
remove it?
Otherwise the change is good.
Cheers.
--
Paul Bone
http://paul.bone.id.au
More information about the reviews
mailing list