[m-rev.] Refactoring make_temp
sebastian.godelet at outlook.com
Thu May 26 16:28:40 AEST 2016
>From an initial screening I think you preserved all the additions I made, but I've yet to build this.
Couple of things though:
In line 10935 (https://github.com/Mercury-Language/mercury/compare/master...PaulBone:make_temp#diff-c8358543868f79aa0b536505b8138fbaR10935) you comment out a huge bunch of code,
I'd rather rely on version management instead (so git blame and stuff continue to work); also I think io.m is already large enough.
In line 11226, you changed have_make_temp_directory to always return MR_TRUE, maybe we should get rid off the procedure altogether (if I remember that was a new, so unreleased, addition).
I'll try to build this changes later
P.S: I hope I didn't send emails twice or more times my Outlook was giving up on me.
More information about the reviews