[m-rev.] for review: Uncomment foreign code definition for clock/3.
paul at bone.id.au
Wed May 25 11:31:01 AEST 2016
On Tue, May 24, 2016 at 03:38:33PM +0800, Sebastian Godelet wrote:
> Hello Paul,
> > -----Original Message-----
> > From: reviews [mailto:reviews-bounces at lists.mercurylang.org] On Behalf Of
> > Paul Bone
> > Sent: Tuesday, May 24, 2016 15:11
> > To: Mercury Reviews <reviews at lists.mercurylang.org>
> > Subject: [m-rev.] for review: Uncomment foreign code definition for clock/3.
> > While I was working on temprary files I thought I needed this to help
> > generate random filenames, but time/3 is better. Anyway I seem to have
> Note that with time based file names you lose the security aspect of random file generation,
> as this is a highly-predictable element.
Agreed, I'll keep this as-is now. The change might be worse for backends
like C but it'll make the backends mostly-consistent. The code can easily
be changed if we get a better cross-platform way to seed the PRNG.
Thanks for the review.
More information about the reviews