[m-rev.] for post-commit review: determinism error messages
zoltan.somogyi at runbox.com
Fri May 13 12:27:03 AEST 2016
On Fri, 13 May 2016 09:44:25 +1000, Paul Bone <paul at bone.id.au> wrote:
> There is an opportunity for optimisation here. Rather than building up a
> set of contexts you only need to track the smallest context seen so far.
You are right, which is why I am committing the attached diff.
> The code is correct how it is and already committed, so I wouldn't worry
> about it unless we wanted, for some reason, to improve the performance of an
> error handling routine (rarely executed).
While the context this code sets is only USED when there is an error,
the code itself is EXECUTED every time a switch is detected.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2570 bytes
Desc: not available
More information about the reviews