[m-rev.] for review: Simplify implementation of all-solutions predicates.

Julien Fischer jfischer at opturion.com
Wed Mar 30 15:03:14 AEDT 2016


Hi Peter,

On Tue, 29 Mar 2016, Peter Wang wrote:

> library/builtin.m:
> 	  Mark get_one_solution/1 and get_one_solution_io/4 obsolete.
> 	  They were once used to implement all-solutions predicates but
> 	  are now only used in the implementation of other deprecated
> 	  predicates in the builtin module.
>
> library/solutions.m:
> 	  Make builtin_solutions, builtin_aggregate, builtin_aggregate2
> 	  actually cc_multi.
>
> 	  Move the promise_equivalent_solutions lie up from non_cc_call
> 	  into its callers.  Delete non_cc_call.
>
> 	  Conform to changes.

That looks fine.  (There is some special handling of the
builtin_aggregate family of predicates in the declarative debugger, but
I don't think that should be affected by this.)

Julien.


More information about the reviews mailing list