[m-rev.] for review: Avoid memory allocation for common string to int conversions.
Julien Fischer
jfischer at opturion.com
Mon Jun 20 14:28:16 AEST 2016
Hi Peter,
On Mon, 20 Jun 2016, Peter Wang wrote:
> It might only be worth doing this for decimal and hexadecimal.
> Octal and binary are not really very common.
> ---
>
> library/string.m:
> Make base_string_to_int pass a constant higher order term
> to string.foldl_between for common bases 10, 16, 8, 2.
That looks fine. I assume (at least at the default optimisation level)
the compiler isn't specialising the foldl_between calls? At least
for the decimal case that may be worth looking at as well.
Julien.
More information about the reviews
mailing list