[m-rev.] for review: fix mantis bug 412

Zoltan Somogyi zoltan.somogyi at runbox.com
Sun Jul 17 04:53:19 AEST 2016


On Sat, 16 Jul 2016 12:07:56 +1000, Peter Wang <novalazy at gmail.com> wrote:
> The proposed change will cause the compiler to warn about a module
> being unused if it is imported ONLY for a class definition, even if it
> is necessarily imported by the current module in order to define an
> instance of that class.

Thanks. I discovered that problem myself just before I got your email.

> Perhaps a fix is along these lines: only instances defined in "this"
> module should "use" the modules defining the class and types in the
> instance.  Instances defined in imported modules would be ignored.

I think that works. Here is an updated diff that uses your approach,
not the one I used originally.

Zoltan.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.bug412a
Type: application/octet-stream
Size: 3004 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20160716/ee2c8430/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.bug412a
Type: application/octet-stream
Size: 37721 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20160716/ee2c8430/attachment-0003.obj>


More information about the reviews mailing list