[m-rev.] for review: Fix a bug with IO errors while reading files
Paul Bone
paul at bone.id.au
Wed Aug 31 13:50:07 AEST 2016
On Mon, Aug 29, 2016 at 09:39:25AM +1000, Julien Fischer wrote:
>
> Hi Paul,
>
> On Fri, 26 Aug 2016, Paul Bone wrote:
>
> >Fix a bug with IO errors while reading files
>
> s/IO/I\/O/. (I'm not so worried about the log message, but the code
> in library/io.m uses the latter.)
Done.
>
> The diff looks fine; it would also be useful to add a regression test for
> this one. (Also, I assume you have checked that other backends are not
> affected by this?)
I've checked just now, they seem to be fine. If they were faulty it'd be a
very strange copy and paste error. Who would copy C code into Java?!
Yeah, a regression test is a good idea.
--
Paul Bone
http://paul.bone.id.au
More information about the reviews
mailing list