[m-rev.] for post-commit review: pretty_printer.m
Sebastian Godelet
sebastian.godelet at outlook.com
Sun Aug 7 13:00:14 AEST 2016
Hi Zoltan,
Concerning set_formatter_sv, maybe code could be refactored that instead of
set_formatter_sv(ModuleName, TypeName, Arity, Formatter, FMap0, FMap) :-
FMap = set_formatter(ModuleName, TypeName, Arity, Formatter, FMap0).
set_formatter is defined as:
set_formatter(ModuleName, TypeName, Arity, Formatter, !.FMap) :-
!:FMap = set_formatter(ModuleName, TypeName, Arity, Formatter, !FMap).
And all code inside the pretty_printer module is changed to use the _sv function only,
s.th. the original function can be deprecated eventually?
Cheers,
Sebastian.
More information about the reviews
mailing list