[m-rev.] for review: Improve Mercury's temporary files and directories predicates.

Paul Bone paul at bone.id.au
Wed Apr 13 15:14:57 AEST 2016


On Wed, Apr 13, 2016 at 02:15:32PM +1000, Julien Fischer wrote:
> 
> Hi Paul,
> 
> >+
> >+:- pred system_temp_dir(string::out, int::out, io::di, io::uo) is det.
> 
> Use a bool rather than an int for the second argument.
> (bool.YES and bool.NO in Java; mr_bool.YES and mr_bool.NO in C#)
> 

The other suggestions are fine, however I cannot follow through on this one.
Your recent change to allow this for the Java backend needs a couple of
weeks to bootstrap (which I can live with).  And the Erlang backend doesn't
seem to support this.

I'd rather keep using integers until the support is available for all
backends.

Cheers.


-- 
Paul Bone


More information about the reviews mailing list