[m-rev.] the grade library is ready for review

Zoltan Somogyi zoltan.somogyi at runbox.com
Tue Apr 5 15:05:30 AEST 2016



On Tue, 5 Apr 2016 14:20:43 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:

> 
> 
> On Fri, 1 Apr 2016, Zoltan Somogyi wrote:
> 
> > The try_all_grade_structs program is a sanity check; it tests whether
> > the grade library can properly process all valid grades (of which there
> > are more than one million!). This takes a bit less than a minute on
> > my laptop, which shows that the grade library can handle the kinds
> > of problems that this test poses in about 50 microseconds each.
> > (I expect that solving partial, not full, grade specifications takes longer.)
> 
> Another one.
> 
>      #error "MR_USE_MINIMAL_MODEL_OWN_STACKS requires MR_CONSERVATIVE_GC"
> 
> However, try_all_structs generates:
> 
>      TEST 59941: grade struct none.mmos
>      TEST 59942: grade struct none.spf.mmos
>      TEST 59943: grade struct none.pregen.mmos
> 
> etc.
> 
> Ditto for the mmsc grades.

Again, this constraint is not in mercury_grade.h, but in mercury_conf_param.h
I will add the constraints from there, and, to be sure, will grep all the runtime's
header files for all the macros that represent grade components.

Zoltan.




More information about the reviews mailing list