[m-rev.] for post-commit review: use error_specs in handle_options.m

Zoltan Somogyi zoltan.somogyi at runbox.com
Tue Oct 13 18:25:37 AEDT 2015


The rationale for this diff is that the code that selects the op_mode
uses error_util too. We agreed that we should select the op_mode
as part of option processing, and this prepares for that by eliminating
a difference that would complicate the review of the diff that does
that merge.

I was going to move that code to handle_options.m, but I think
it would be better to move it to a new module (I propose op_mode.m.),
and also move the code currently in handle_options.m that computes
the grade and handles the implications of grades to another new module,
named (say) compute_grade.m. Any opinions, or objections?

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.option_specs
Type: application/octet-stream
Size: 694 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20151013/4c7c2dc9/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.option_specs
Type: application/octet-stream
Size: 92696 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20151013/4c7c2dc9/attachment-0001.obj>


More information about the reviews mailing list