[m-rev.] for review: extend modes of operation

Julien Fischer jfischer at opturion.com
Mon Oct 12 17:24:34 AEDT 2015


(I've just realised this wasn't going to the list.)

On Mon, 12 Oct 2015, Julien Fischer wrote:

>
> On Mon, 12 Oct 2015, Julien Fischer wrote:
>
>> On Mon, 12 Oct 2015, Zoltan Somogyi wrote:
>> 
>>> 
>>> 
>>> On Mon, 12 Oct 2015 11:12:23 +1100 (AEDT), Julien Fischer 
>>> <jfischer at opturion.com> wrote:
>>>> The diff itself looks fine
>>> 
>> 
>> Actually, that said, there appears to be at least one more exception
>> required (this is when building the standard library with mmc --make):
>>
>>    Making Mercury/int3s/version_bitmap.int3
>>    Making Mercury/int3s/version_hash_table.int3
>>    Making Mercury/int3s/version_store.int3
>>    Making Mercury/int0s/thread.int0
>>    Error: only one of the following options may be given:
>>      `--make-private-interface', `--target-code-only' and `--compile-only'.
>
> According to compiler/handle_options.m:1014 the latter two are always
> enabled when --make is. '--make' is always passed through to the its
> subprocesses, although that seems unnecessary as we also pass
> '--invoked-by-mmc-make'.

Does anyone know why we do the following at 
compiler/handle_options.m:1014, it doesn't actually seem necessary.

     option_implies(make, compile_only, bool(yes), !Globals),
     option_implies(make, target_code_only, bool(yes), !Globals),

If it *is* necessary then we shouldn't be doing until after we have 
checked the value of --invoked-by-mmc-make and potentially disabled
--make (a few lines further down).

Julien.



More information about the reviews mailing list