[m-rev.] for post-commit review: don't abort on curried preds with no declared determinism
Paul Bone
paul at bone.id.au
Wed Oct 7 10:44:14 AEDT 2015
On Wed, Oct 07, 2015 at 12:44:09AM +1100, Zoltan Somogyi wrote:
> Most of the change is pretty simple; the only part worth reviewing
> is the text of the error message. (See the very last part of the diff.)
+higher_order_no_detism.m:024: Error: the predicate
+higher_order_no_detism.m:024: `higher_order_no_detism.short' has no
declared
+higher_order_no_detism.m:024: determinism, so a curried call to it may
not be
+higher_order_no_detism.m:024: used as a lambda expression.
It'd be nice of that last part was more sucinct. But I don't think there's
a way to do that without changing the meaning.
I forget, does this affect all higher order arguments?
+ A curried argument (like this one): Yes.
+ A higher order argument that doesn't need currying.
+ An explicit lambda.
I ask because generalising the error message may help. The last part of the
message could read "so it cannot be used as a higher order argument", for
example.
Cheers.
--
Paul Bone
More information about the reviews
mailing list