[m-rev.] for review: insts in mode error messages

Zoltan Somogyi zoltan.somogyi at runbox.com
Sun Nov 29 04:39:24 AEDT 2015

On Sat, 28 Nov 2015 21:28:44 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
> > I would like the review to answer a question: should the predicates that
> > convert insts to format components be put into a new module or not? There is
> > another place in the compiler that could use them; the code that reports
> > invalid insts in mutable declarations.
> Yes, they should be moved to a separate module.

Would error_msg_inst.m be a suitable name for that module?
> > +        % XXX Should we special case the expanded versions of other
> > +        % "builtin" modes?
> The special cases should also include ui, mdi, muo and mui.

Ok, done. I have committed the diff, without moving stuff to
the new module; I am waiting for a review of the module name for that.


More information about the reviews mailing list