[m-rev.] for review: direct parsing of goals

Zoltan Somogyi zoltan.somogyi at runbox.com
Mon Nov 23 17:09:52 AEDT 2015

On Mon, 23 Nov 2015 16:47:46 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
> The test suite should also be updated to cover the error messages added or
> modified below.

There ARE no test cases affected by the modified messages.
People tend to use language constructs correctly; if they don't,
due e.g. to a typo, they fix the error and move on without
filing a bug report about the error message :-(

I will add some test cases for the new error messages, but later;
I plan on making some other modifications first. However, I would
be grateful if people who work with exceptions would send me,
or add directly to tests/invalid, examples of real code that had
syntax errors in try goals.

> > +            (
> > +                MaybeCatchAnyExpr = ok1(CatchAnyExpr),
> > +                % YYY
> What's YYY in aid of?

Nothing; just a marker so I didn't have to remember a line number.

I followed your other suggestions.


More information about the reviews mailing list