[m-rev.] for review: Build string switch tries in the target string encoding.
Julien Fischer
jfischer at opturion.com
Mon Mar 23 17:49:36 AEDT 2015
Hi Peter,
On Mon, 23 Mar 2015, Peter Wang wrote:
> On Mon, 23 Mar 2015 11:53:12 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
>>
>> Hi Peter,
>>
>> On Tue, 17 Mar 2015, Peter Wang wrote:
>>
>>> Build string switch tries in the target string encoding.
> ...
>>
>> That looks fine.
>
> Committed with the int emulation patch.
>
> Any opinion on what to do about the mentions of --cross-compiling in the
> documentation? It has no effect now but presumably could in the future.
Comment out the documentation. Leave the option around since there are
existing scripts (e.g. the ones that build the ROTDs) that still use it.
(Since some of those scripts are also used with 14.01 where it *does*
have an effect we can't simply delete the use of the option.)
Cheers,
Julien.
More information about the reviews
mailing list