[m-rev.] for review: more speeds in inst handling

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu Mar 5 18:29:19 AEDT 2015



On Thu, 5 Mar 2015 17:38:07 +1100, Peter Wang <novalazy at gmail.com> wrote:
> >          Inst0 = defined_inst(_InstName),
> >          % ZZZ
> >          Groundness = inst_result_groundness_unknown,
> >          ContainsAny = inst_result_contains_any_unknown,
> > -        ContainsInstNames = inst_result_contains_instnames_unknown,
> > +        ContainsInstNames = inst_result_contains_inst_names_unknown,
> > +        ContainsInstVars = inst_result_contains_inst_vars_known(set.init),
> 
> inst_result_contains_inst_vars_unknown?

Actually, the predicate this code is in is called only if there are no sources
of inst_vars, so the code above is right. I added a comment to this effect.

I followed all your other suggestions. Thanks for the review.

Zoltan.





More information about the reviews mailing list