[m-rev.] diff: break up add_pragma and make_hlds_passes

Julien Fischer jfischer at opturion.com
Tue Jan 27 12:50:55 AEDT 2015


Hi Zoltan,

On Tue, 27 Jan 2015, Zoltan Somogyi wrote:

> On Tue, 27 Jan 2015 12:17:07 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
>> One of your recent changes to the handling of mutables has broken
>> compilation of the standard library in the C# grade (and probably the
>> other non-C grades):
>>
>>     ...
>>     Making Mercury/opts/pqueue.opt
>>     Making Mercury/opts/pretty_printer.opt
>>     pretty_printer.m:878: In predicate `set_io_pp_params'/3:
>>     pretty_printer.m:878:   warning: unnecessary `promise_pure' pragma.
>>     For more information, recompile with `-E'.
>>     ** Error making `Mercury/opts/pretty_printer.opt'.
>
> I will have a look. In the meantime, turning off halt-at-warn
> should allow it to compile again.
>
> By the way, has everyone installed the change to track format
> strings through appends? I can't push the diff for enabling
> warnings about unknown format strings until this has been done.

The above error occurred while I was attempting to build the ROTD that
includes the change to track format strings through appends.
You should wait until there has been a successful ROTD build including
that change before you commit the next bit.

Cheers,
Julien.



More information about the reviews mailing list