[m-rev.] diff: break up add_pragma and make_hlds_passes

Julien Fischer jfischer at opturion.com
Tue Jan 27 12:17:07 AEDT 2015


Hi Zoltan,

On Fri, 23 Jan 2015, Zoltan Somogyi wrote:

> This breakup resolves several of the ZZZs in my recent change.
>
> This diff just moves code around, so no review is needed, but just for information,
> before this change, the sizes of those modules were, as reported by wc:
>
> 3847  12610 169514 add_pragma.m
> 3292  10973 134996 make_hlds_passes.m
>
> and after it they are
>
> 1522   4915  66545 add_pragma.m
> 1356   4431  56966 make_hlds_passes.m
>
> add_mutable_aux_preds.m is now bigger than make_hlds_passes.m,
> the module it was carved out of.

One of your recent changes to the handling of mutables has broken
compilation of the standard library in the C# grade (and probably the
other non-C grades):

    ...
    Making Mercury/opts/pqueue.opt
    Making Mercury/opts/pretty_printer.opt
    pretty_printer.m:878: In predicate `set_io_pp_params'/3:
    pretty_printer.m:878:   warning: unnecessary `promise_pure' pragma.
    For more information, recompile with `-E'.
    ** Error making `Mercury/opts/pretty_printer.opt'.

Cheers,
Julien.



More information about the reviews mailing list