[m-rev.] for review: Make base_string_to_int check overflow/underflow for all bases.
Peter Wang
novalazy at gmail.com
Tue Feb 17 12:34:27 AEDT 2015
On Mon, 16 Feb 2015 15:43:31 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
>
> On Mon, 16 Feb 2015, Peter Wang wrote:
>
> > On Mon, 16 Feb 2015 13:07:49 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
> >>
> >> Hi Peter,
> >>
> >> On Mon, 16 Feb 2015, Peter Wang wrote:
> >>>
> >>> I also considered using `integer' in place of the string representation.
> >>> What do you think?
> >>
> >> On balance, I don't have any objection to doing that. 'integer' is
> >> certainly a safer representation than 'string'.
I've committed it, using the `integer' representation.
Peter
More information about the reviews
mailing list