[m-rev.] for review: Some `integer' module improvements.

Julien Fischer jfischer at opturion.com
Mon Feb 16 17:24:01 AEDT 2015


Hi,

On Mon, 16 Feb 2015, Peter Wang wrote:

> Some `integer' module improvements.
>
> library/integer.m:
> 	Add basic documentation for interface predicates and functions.
>
> 	Throw math.domain_error exceptions where the analogous
> 	predicates and functions in the `int' module would do so.
>
> 	Throw exceptions with unexpected/3 where that would indicate an
> 	implementation error.
>
> 	Fix looseness in the strings that from_base_string accepted,
> 	e.g. "+" and "--1".
>
> 	Minor style changes.

That looks fine.

Cheers,
Julien.



More information about the reviews mailing list