[m-rev.] for post-commit review: fix io section of transition guide
Zoltan Somogyi
zoltan.somogyi at runbox.com
Wed Feb 11 15:34:48 AEDT 2015
On Wed, 11 Feb 2015 15:02:46 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
> > Since there are separate versions of MR_hash_string5 and friends for GCC
> > and non-GCC, I suspect the issue is that the non-GCC version has not
> > been tested.
That is correct.
> In particular, don't you need definitions of MR_hash_string[45] in
> runtime/mercury_string.c? (As per MR_hash_string[123]?)
Yes, and forward declarations in mercury_string.h as well.
I was testing this fix with clang a few minutes ago when my laptop shut down
unexpectedly, due to overheating. Since the cover of the CPU compartment
is still very hot, I won't be able to turn it back on for a while.
Zoltan.
More information about the reviews
mailing list