[m-rev.] for review by Julien: Fix handling of newlines in configure.ac.
Paul Bone
paul at bone.id.au
Thu Feb 5 14:56:32 AEDT 2015
On Thu, Feb 05, 2015 at 11:24:41AM +1100, Julien Fischer wrote:
>
> Hi Paul,
>
> On Wed, 4 Feb 2015, Paul Bone wrote:
>
>> Branches: master, version-14_01-branch
>>
>> Julien, does my solution make sense to you? You know more about platform
>> independance than I do.
>
> I think omitting the newline in the output of the configure tests, as
> you do in your change, is the best solution here. (It should be
> possible to configure the shell to avoid the problem, but that's a more
> brittle solution as it relies on the user having done that.)
Thanks, I've made those changes.
I've put it on the version-14_01-branch anyway because I'm doing this for a
work thing and I'd prefer to use something close to a major version. I'll
merge the changes onto master after I've some other changes I"m working on.
Cheers.
--
Paul Bone
More information about the reviews
mailing list