[m-rev.] for review: only_opmode

Julien Fischer jfischer at opturion.com
Wed Dec 30 01:31:26 AEDT 2015

On Wed, 30 Dec 2015, Zoltan Somogyi wrote:

> On Tue, 29 Dec 2015 23:11:24 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
>> The implementation is not perhaps inot so straightforward ... building
>> the library (as part of a full build) in the C# grade gives:
>>      Uncaught Mercury exception:
>>      Software Error: predicate
>>     `make.dependencies.check_dependency_timestamps'/10: Unexpected: OpMode
>>      != opm_top_make
> I cannot reproduce this error, since I don't have C# installed, and get
> an error before the make gets there.

The C# part was a bit misleading, the same thing occurs with the C
grades when building with --use-mmc-make.  (I hadn't tried the latter
at the time I wrote my mail.)

> However, I looked at the code that throws that exception, and my
> only_opmode change expected an invariant (that this code is invoked
> only with --make or --rebuild) that isn't actually valid. So I just
> committed a change to avoid making that assumption.  Please test
> whether this fixes the problem.

Yes, that appears to fix the problem.



More information about the reviews mailing list