[m-rev.] for review: --warn-dead-procs-with-live-siblings

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu Dec 10 15:29:49 AEDT 2015



On Thu, 10 Dec 2015 15:14:39 +1100, Peter Wang <novalazy at gmail.com> wrote:
> I agree with the default behaviours.

Thanks for the review.

> Perhaps name the option --warn-all-dead-procs instead.

I think that having both --warn-dead-procs and --warn-all-dead-procs
be confusing.

How about --warn-dead-procs and --warn-dead-preds?
The former doing what it always did, and the latter warning
only about predicates in which all procedures are dead.

> Delete the first --no-warn-target-code line.

Will do.

Zoltan.





More information about the reviews mailing list