[m-rev.] for review: Remove Cygwin hacks in boehm_gc/Makefile.direct

Peter Wang novalazy at gmail.com
Tue Aug 25 15:50:27 AEST 2015


On Tue, 25 Aug 2015 15:13:19 +1000, Peter Wang <novalazy at gmail.com> wrote:
> On Tue, 25 Aug 2015 15:08:28 +1000 (AEST), Julien Fischer <jfischer at opturion.com> wrote:
> > 
> > Hi Peter,
> > 
> > On Tue, 25 Aug 2015, Peter Wang wrote:
> > >
> > > Note that those lines were incorrectly merged into Boehm GC upstream.
> > 
> > Presumably you intend to send a patch that removes them from upstream?
> 
> Yes, I will suggest it.

On second thought, it's not really wrong (I'll delete that from the log
message).  Someone using Cygwin might well set CC to a shell script.
The non-shell script case is handled one line earlier.

Peter



More information about the reviews mailing list