[m-rev.] for review: Remove Cygwin hacks in boehm_gc/Makefile.direct
Julien Fischer
jfischer at opturion.com
Tue Aug 25 15:08:28 AEST 2015
Hi Peter,
On Tue, 25 Aug 2015, Peter Wang wrote:
> We had these kind of lines:
>
> -./if_not_there mach_dep.o `cygpath -w /bin/sh` $(CC) ...
> -./if_not_there mach_dep.o /bin/sh $(CC) ...
>
> They would have been necessary because $(CC) actually points to mgnuc,
> a shell script, which the if_not_there.c program might not be able to
> start with execvp().
>
> Now that we have replaced if_not_there.c with a shell script, there
> should be no need to refer to invoke /bin/sh explicitly.
>
> Note that those lines were incorrectly merged into Boehm GC upstream.
Presumably you intend to send a patch that removes them from upstream?
> boehm_gc/Makefile.direct:
> As above.
That's fine.
Julien.
More information about the reviews
mailing list