[m-rev.] for review: rewrite of vim syntax file

[Sebastan Godelet]

Hi Peter,

I followed your advice and changes, I've attached a diff based on
master.
I tried to reapply to your experimental branch but for some reason that
failed. Sorry for this.
There are two places with an "sg -" prefix, I'd like some feedback on
that when you have time.

Sebastian.

On Wed, 15 Apr 2015 12:00:06 +1000
Peter Wang <novalazy at gmail.com> wrote:

> On Tue, 14 Apr 2015 15:26:09 +0800, Sebastian Godelet
> <sebastian.godelet at outlook.com> wrote:
> >
> > Would you mind rebasing your diff to the current master (that one
> > has the colouring for head clauses already addressed) if possible?
> > If that's not possible, then I'll do it by hand.
> 
> It's here: https://github.com/wangp/mercury-experimental/tree/vim
Thanks for this.
> 
> > 
> > In your diff, you marked these <Fx> keyboard commands as
> > conflicting: " <F6> attempts to wrap a call up with { } braces for
> > DCG escapes. "
> > -nnoremap <F6> I{ <ESC>%a }<ESC>j
> > +" pw - conflicts
> > +" nnoremap <F6> I{ <ESC>%a }<ESC>j
> 
> Sorry, it only conflicts with my own <F6> binding.
Do you think that many users are using this?
I find your keybindings far more useful.
> 
> >     " <F7> and <F8> comment and uncomment lines out respectively.
> >     "
> > -nnoremap <F7> 0i% <ESC>j
> > -nnoremap <F8> :s/% //e<CR>j
> > +" pw - should only be applicable to mercury
> > +" nnoremap <F7> 0i% <ESC>j
> > +" nnoremap <F8> :s/% //e<CR>j
> > 
> > These I didn't touch (at least I can't recall that), as far as I 
> > remember there were like this in the original version.
> 
> Never mind, I just use something else for toggling comments which
> works for multiple languages.
Would you mind to share?
> 
> > Also about the comment line length, I just adjusted the line length
> > to the one in the standard library, e.g. from io.m (77):
> > %---------------------------------------------------------------------------%
> > Before it was 80 chars but I remember that I once read on the
> > mailing list that this was deemed to long once.
> > Maybe I just miscount. Hope you can clarify on this.
> 
> I see, the old plugin had it at 80 chars but I had modified my copy
> ages ago to 79 chars.  Now some files are moving to 77 chars.  Fine.
I think the reasoning is that with less than 79, sending and quoting
diffs in emails is much easier
> 
> Peter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-after-peter.diff
Type: text/x-patch
Size: 28920 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20150415/b81afb59/attachment.bin>