[m-rev.] diff: do not pass -ansi to GCC on any system
Peter Wang
novalazy at gmail.com
Tue Sep 23 18:04:03 AEST 2014
On Tue, 23 Sep 2014 17:21:50 +1000 (EST), Julien Fischer <jfischer at opturion.com> wrote:
>
> On Tue, 23 Sep 2014, Peter Wang wrote:
> >> NOTE: this is *not* an invitation to start using C99 language features
> >> throughout the runtime and library -- at this point, we (unfortunately) still
> >> maintain compatibility with older versions of MSVC that don't support these
> >> features.
> >>
> >> configure.ac:
> >> Do not pass -ansi to GCC. Add an explanation of why.
> >>
> >> scripts/mgnuc.in:
> >> Update the description of the what the --no-ansi option does.
> >> (XXX there's _a lot_ of out-of-date stuff in this script.)
> >
> > So after this change, mmc --ansi-c is still the default but actually
> > does nothing with any compiler,
>
> Yes, although it is hasn't done anything with C compilers other than GCC
> for a while now.
>
> > and mgnuc --ansi is the default but it
> > doesn't pass -ansi anywhere, but does pass -D__EXTENSIONS__ -D_GNU_SOURCE?
>
> The latter behaviour was what prompted my XXX comment, since I'm pretty
> sure mmc --make, for example, doesn't replicate that behaviour. Also,
> why define _GNU_SOURCE on systems that do not use the GNU C library?
I agree, that's wrong.
__EXTENSIONS__ and _GNU_SOURCE were defined for lcc in commits 2fd0c764
and a68373aa. I think we can remove those flags and see if anyone
notices.
Peter
More information about the reviews
mailing list