[m-rev.] diff: speed up is_finite/1 and is_nan/1 in C grades

Peter Wang novalazy at gmail.com
Fri Sep 19 17:44:36 AEST 2014


On Wed, 17 Sep 2014 12:01:14 +1000 (EST), Julien Fischer <jfischer at opturion.com> wrote:
> @@ -136,7 +136,7 @@ MR_is_nan(MR_Float Flt)
>   }
> 
>   MR_bool
> -MR_is_inf(MR_Float Flt)
> +MR_is_inf_func(MR_Float Flt)
>   {
>       /*
>       ** On Solaris, isinf() is detected by configure but we pass -fno-builtin

Fixed the name.

isinf/isnan/finite are not C89 so I get these warnings due to
--no-ansi-c.

float.m: In function ‘float_module22’:
float.m:718:5: warning: implicit declaration of function ‘isinf’ [-Wimplicit-function-declaration]
float.m: In function ‘float_module23’:
float.m:680:5: warning: implicit declaration of function ‘isnan’ [-Wimplicit-function-declaration]
float.m: In function ‘float_module26’:
float.m:753:5: warning: implicit declaration of function ‘finite’ [-Wimplicit-function-declaration]

Not sure what the fix should be.

Peter




More information about the reviews mailing list