[m-rev.] for post-commit review: fix mantis bug 361

[Julien Fischer]

On Wed, 17 Sep 2014, Zoltan Somogyi wrote:

> On Thu, 18 Sep 2014 01:50:52 +1000 (EST), Julien Fischer <jfischer at opturion.com> wrote:

>> Modifiers: gc, prof, memprof, profdeep, tr, trseg, spf, stseg, debug,
>>             decldebug, par, ssdebug, threadscope, pregen
>>
>> * I have long intended to make 'tr' imply 'trseg' and get rid of the latter,
>>    so in the long term it will go.
>
> Is there any reason why we cannot NOW add a 'trnoseg' grade component,

I don't think that it is worth having a separate grade component for the
fixed size trail.  Its main use now is as a baseline for measuring the
cost of the trail segments mechanism.  Since that's something that only
developers will want to do, I happy enough for it to be controlled via a
C macro.

> and make tr be a synonym for trseg?

I don't think there is any problem with doing that now.

>> * 'threadscope' seems to spend more time broken than working, but I think
>>    Paul still intends to do something with it.
>
> The question is, is it currently useful to people who are not Mercury
> developers?
>
> The answer is of course more likely to be "yes" if we target a fixed
> version of Threadscope.

I'll leave this one up to Paul.

...

>> There are no objections from me (obviously!).
>> For the grade-component options, I suggest the following scheme:
>>
>>     --add-grade-component-<feature>
>>     --remove-grade-component-<feature>
>
> That would work, but we should also think about shorter names,
> such as --add-to-grade and --remove-from-grade, even if they
> are not quite as precise.

I was expecting that we would also add shorter synonyms for them.

>> For example:
>>
>>     --add-grade-component-debug
>>     --add-grade-component-decldebug
>>     --add-grade-component-parallelism
>>     etc
>
> I think the name of the grade component should be accepted
> both when spelled out in full (e.g. parallelism) and when abbreviated
> (e.g. par).

Also fine by me.

Cheers,
Julien.