[m-rev.] for review: standardise formatting of float special values
Julien Fischer
jfischer at opturion.com
Tue Sep 16 14:19:02 AEST 2014
On Tue, 16 Sep 2014, Zoltan Somogyi wrote:
> On Tue, 16 Sep 2014 13:47:06 +1000 (EST), Julien Fischer <jfischer at opturion.com> wrote:
>> Is there anyone willing to review this one?
>
> I had a look. I am not an expert on this, but the diff looks
> ok to me. The only small inconsistency I found is in style;
> the diff replaces the "inf" in predicate names with "infinity"
> in Mercury code in the library, but the C macro in the runtime
> is still named MR_is_inf().
There will be an inconsistency somewhere given that the underlying macro
for this in C is named isinf. It depends whether the names in the
runtime should follow the Mercury name or the C name. (C99 is not
terribly consistent with itelf here since the macro for testing whether
a floating point number is finite is named isfinite.)
I'm in the process of adding more classification predicates to the float
module, so I will deal with this as part of that change.
Cheers,
Julien.
More information about the reviews
mailing list