[m-rev.] for review: report errors for bad ":- end_module" declarations

Zoltan Somogyi zoltan.somogyi at runbox.com
Mon Sep 1 21:53:21 AEST 2014



On Mon, 1 Sep 2014 16:45:37 +1000 (EST), Julien Fischer <jfischer at opturion.com> wrote:
> Once this is committed you can mark bug #41 in Mantis as resolved.

Will do.

> >     Simplify the code we used to use to remove the :- module/:- end_module
> >     wrappers around the top level module. It seems to be the loosening
> >     of the checks in this code, more than a decade ago, to account for
> >     the possibility of the final :- end_module in a file's item list
> >     being for a submodule of the main module, not the main module itself,
> >     that I think previously let the malformed item list through to be
> >     processed by later compiler passes, which did not expect it.
> 
> That last sentence is very awkward.

Replaced that paragraph with:

    Simplify the code we used to use to remove the :- module/:- end_module
    wrappers around the top level module. The root of the problem used
    to be that this code used to let a malformed item list through to be
    processed by later compiler passes, which did not expect it.
    The reason WHY it let through malformed item lists seems to be
    the loosening of the checks in this code, more than a decade ago.
    This was done to account for the possibility that the final :- end_module
    in a file's item list is for a submodule of the main module, and not
    for the main module itself.

> > doc/reference_manual.texi:
> >     Fix bad punctuation, and expand the list of things
> >     that can be declared but defined.
> 
> that can be declared but defined?  that can be declared and must be defined?

... that can be declared but NOT defined.
 
> I know that's mostly the existing text but that's confusing because 

I will reword that paragraph, as my next change.

> The diff itself looks fine.

Thank you.

Zoltan.





More information about the reviews mailing list