[m-rev.] for review: report errors for bad ":- end_module" declarations

Julien Fischer jfischer at opturion.com
Mon Sep 1 16:49:48 AEST 2014


On Mon, 1 Sep 2014, Zoltan Somogyi wrote:

> For review by anyone. Note that before commit, I intend to add
> a more extensive test case (or several) to test each of the problems
> with :- module and :- end_module declarations that the newly added
> code tests for.

There are several existing entries in Mantis (reachable from bug #41 --
the others were marked as duplicates).  You should make sure they now
work.

> After this diff, I also intend to break up two modules. I intend to move
> the functionality operating on sym_names out of mdbcomp/prim_data.m,
> since it does not fit with the rest of that module, and I intend to move
> parse_item and its call tree out of prog_io.m, leaving prog_io.m dealing
> only with the top level handling of modules. Both of these should
> improve cohesion, and the latter should also avoid a circular import
> between prog_io and prog_io_typeclass. Are there any objections?

Not from me.

Cheers,
Julien.



More information about the reviews mailing list