[m-rev.] for review: move much stuff out of modules.m
Paul Bone
paul at bone.id.au
Fri Oct 17 11:29:49 AEDT 2014
On Thu, Oct 16, 2014 at 01:54:55PM +0200, Zoltan Somogyi wrote:
> For review by anyone. The diff is mostly straightforward, but I would like people's
> opinion on whether the code I have put into the new module_deps_graph.m
> should instead go into the existing module deps_map.m.
>
I've taken a look but I have no strong oppinion either way. A comment at
the top of module_deps_graph might be useful, while it's pretty obvious it
couldn't hurt. The relationship with deps_map isn't obvious when you read
module_deps_graph first.
Maybe as a seperate change we could rename deps_map.m to module_deps_map.m
Thanks.
--
Paul Bone
More information about the reviews
mailing list