[m-rev.] for review: specialize all calls to {string, io}.format
Zoltan Somogyi
zoltan.somogyi at runbox.com
Sun Nov 30 18:49:53 AEDT 2014
On Sun, 30 Nov 2014 18:36:55 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
> > Do you have code that I can use as a more substantial test of correctness,
> > even if it doesn't help decide which implementation approach to pick?
>
> Looking through the libraries I have written that use streams I only
> found two calls to string_writer.format. I can construct an artifical
> test case based on the tests we already have for string.format which
> will probably more useful here.
I can do that myself enough, so don't bother. I was after more real
tests, but it seems that these are out of reach.
> One other thing: do you specialize format calls in debugging grades?
At the moment, yes.
I agree with your implicit point about this probably not being what
users expect, so I will turn off optimize_format_calls when debugging
is enabled. We could add yet another option to turn it on even in
debugging grades, but I don't think there is much point in that.
Zoltan.
More information about the reviews
mailing list