[m-rev.] for post-commit review: require_switch_arms_{det,...}

Zoltan Somogyi zoltan.somogyi at runbox.com
Wed Nov 19 17:24:51 AEDT 2014

On Wed, 19 Nov 2014 16:54:57 +1100 (AEDT), Julien Fischer <jfischer at opturion.com> wrote:
> > +If @var{Goal} is a switch on @var{Var},
> > +and all arms of the switch would be allowable in a det context,
> > + at code{require_switch_arms_det [@var{Var}] @var{Goal}}
> The end of that sentence is missing.  Presuambly it's supposed to be
> something like:
>      ... is equivalent to @var{Goal}.

Yes, exactly. Thanks for catching it.

> > +It is thus ok to have a det switch arm
> > +in a @code{require_switch_arms_semidet} scope,
> > +even though it would not be ok
> > +to have a det goal in a @code{require_semidet} scope.
> I suggest prefixing that last bit with "For example,".


Thanks for the review.

More information about the reviews mailing list