[m-rev.] for review: Fix resource leaks in dir fold predicates.

Paul Bone paul at bone.id.au
Tue May 13 15:16:25 AEST 2014


On Tue, May 13, 2014 at 03:00:48PM +1000, Peter Wang wrote:
> On Tue, 13 May 2014 14:09:09 +1000, Paul Bone <paul at bone.id.au> wrote:
> > On Mon, May 12, 2014 at 04:38:26PM +1000, Peter Wang wrote:
> > > The directory stream was not closed if dir.open succeeded in opening
> > > the directory, but failing to read the first entry (which may be as
> > > simple as an empty directory).
> > > 
> > > The directory stream was also not closed when dir.foldl2_process_dir2
> > > returns an error value.
> > > 
> > 
> > This looks fine to me.
> > 
> > It should probably also go on the version-14.01-branch with a breif note in
> > the NEWS file.
> 
> The expected output might be useful, too.

Yes :-)


-- 
Paul Bone



More information about the reviews mailing list