[m-rev.] diff: disable exectuable stripping on Mac OS X for now

Julien Fischer jfischer at opturion.com
Thu May 1 11:46:37 AEST 2014


Branches: 14.01, master.

I'll implement the long term fix descibed below, but I'm going to commit
this now since it means that the next rotd / 14.01.1-beta won't be broken
on Mac OS X.

================================================

Disable executable stripping on Mac OS X for now.

Currently attempting to run dynamically linked executables that are stripped
fails in the presence of programs that use env runtime trace goal conditions.
This is because stripping such executables with just "strip" (as we currently
do) removes the global variable introduced by env runtime trace goal
conditions.  (The long term fix is to invoke strip with the -x flag, but this
needs to be conditional on the value of --mercury-linkage and we currently
don't have the command line options to support that.)

configure.ac:
 	Disable stripping of executables on Mac OS X.

Julien.

diff --git a/configure.ac b/configure.ac
index 7fc1452..a024ce8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1079,7 +1079,11 @@ else
      case "$host" in
          *apple*darwin*)
              LD_STRIP_FLAG=""
-            STRIP_EXE="strip"
+            # XXX we should strip executables as a separate step on Mac OS X,
+            # but doing so correctly requires different flags depending on the
+            # setting of --mercury-linkage and we do not (yet) provide such
+            # fine grained control over executable stripping.
+            # STRIP_EXE="strip"
              ;;
      esac




More information about the reviews mailing list