[m-rev.] for review: Print version information on two lines.

Paul Bone paul at bone.id.au
Tue Mar 11 18:13:10 AEDT 2014


On Tue, Mar 11, 2014 at 04:36:49PM +1100, Peter Wang wrote:
> On Tue, 11 Mar 2014 16:27:03 +1100, Paul Bone <paul at bone.id.au> wrote:
> > 
> > >  :- pragma foreign_proc("Erlang",
> > >  -    library.version(Version::out),
> > >  +    library.version(Version::out, Fullarch::out),
> > >       [will_not_call_mercury, promise_pure, thread_safe],
> > >   "
> > >  -    Version = << ?MR_VERSION "" configured for "" ?MR_FULLARCH >>
> > >  +    Version = MR_VERSION
> > >  +    Fullarch = MR_FULLARCH
> > >   ").
> > > 
> > > ?s and ,
> > 
> > I don't know Erlang, I thought I was just writing assignment operators.
> > 
> > Is this correct?
> > 
> >     Version = << ?MR_VERSION >>
> >     Fullarch = << ?MR_FULLARCH >>
> 
> Erlang syntax is also derived from Prolog so commas separate expressions
> in a sequence.  This code should be correct but please test it:
> 
>     Version = << ?MR_VERSION >>,
>     Fullarch = << ?MR_FULLARCH >>
> 

Okay that worked.  I've tested it by calling library.version in C, Java,
C# and Erlang grades.  I've committed the fix.


-- 
Paul Bone



More information about the reviews mailing list