[m-rev.] for review: Print version information on two lines.
Paul Bone
paul at bone.id.au
Tue Mar 11 16:27:03 AEDT 2014
On Tue, Mar 11, 2014 at 11:40:06AM +1100, Peter Wang wrote:
> On Thu, 6 Mar 2014 10:57:05 +1100, Paul Bone <paul at bone.id.au> wrote:
> >
> > Okay,
> >
> > I think this is reasonable, and I'm not sure which 'looks better' so if you
> > think this looks better I'm happy to go with that. I also want to change
> > the word "for" to "on"
> >
> > Mercury Compiler, version rotd-2013-10-01, on x86_64-unknown-linux-gnu
>
> Hi Paul,
>
> I noticed some syntax errors.
Thanks Peter.
> :- pragma foreign_proc("Erlang",
> - library.version(Version::out),
> + library.version(Version::out, Fullarch::out),
> [will_not_call_mercury, promise_pure, thread_safe],
> "
> - Version = << ?MR_VERSION "" configured for "" ?MR_FULLARCH >>
> + Version = MR_VERSION
> + Fullarch = MR_FULLARCH
> ").
>
> ?s and ,
I don't know Erlang, I thought I was just writing assignment operators.
Is this correct?
Version = << ?MR_VERSION >>
Fullarch = << ?MR_FULLARCH >>
Thanks.
--
Paul Bone
More information about the reviews
mailing list