[m-rev.] for review: Print version information on two lines.

Paul Bone paul at bone.id.au
Tue Mar 4 12:39:32 AEDT 2014


On Tue, Mar 04, 2014 at 12:09:54PM +1100, Peter Wang wrote:
> On Tue,  4 Mar 2014 11:28:36 +1100, Paul Bone <paul at bone.id.au> wrote:
> > For review by anyone.
> > 
> > Branches: master, version-14.01-branch
> > 
> > ---
> > 
> > In the Mercury compiler itself, and in a number of tools we print a version
> > string on one line,
> > 
> >     $ mmc --version
> >     Mercury Compiler, version rotd-2013-10-01, configured for x86_64-unknown-linux-gnu
> >     Copyright (C) 1993-2013 The University of Melbourne
> > 
> > When the version number is sufficiently long, such as for an ROTD release, this
> > will wrap on 80 column terminals.  This change splits these strings into two
> > parts.
> > 
> >     $ mmc --version
> >     Mercury Compiler, version rotd-2013-10-01,
> >     configured for x86_64-unknown-linux-gnu
> >     Copyright (C) 1993-2013 The University of Melbourne
> 
> This change is entirely unnecessary.
> 

Why is it unnecessary?  You should give reasons when stating a position.

> And it definitely does not belong on 14.01.

Okay.

-- 
Paul Bone



More information about the reviews mailing list